Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Upgrade test #1199

Merged
merged 4 commits into from
Aug 16, 2023
Merged

Adding Upgrade test #1199

merged 4 commits into from
Aug 16, 2023

Conversation

nrevanna
Copy link
Contributor

@nrevanna nrevanna commented Aug 10, 2023 •
edited
Loading

Building this test over the functions added in PWX-32648, hence basing it on that branch.

This test case verifies that btrfs  datastores stays on upgrade on a
testbed that qualifies for dmthin.
TestStorageClusterDMthinUpgrade upgrades PX to 3.1 from 3.0 and 2.13
over two iterations. It'll also verify that btrfs was installed.

What this PR does / why we need it:

Which issue(s) this PR fixes (optional)
Closes #

Special notes for your reviewer:
https://jenkins.pwx.dev.purestorage.com/job/3.1.0-dev-jobs/job/vSphere-upgrade-dmthin-opint/

01:15:48.626 --- PASS: TestStorageClusterDMthinUpgrade (2907.73s)
01:15:48.626     --- PASS: TestStorageClusterDMthinUpgrade/BasicUpgradeStorageClusterDmthinWithAllComponents (2907.73s)
01:15:48.629 PASS
01:15:48.629 ==================================================
01:15:48.629 --- PASS:
01:15:48.629     BasicUpgradeStorageClusterDmthinWithAllComponents [C50241]
01:15:48.629 --- SKIP:
01:15:48.629 --- FAIL:
01:15:48.629 ==================================================
01:15:48.638 
01:15:48.638 DONE 2 tests in 2908.025s

@nrevanna nrevanna requested review from a team August 10, 2023 05:20
@github-actions
Copy link

This PR is stale because it has been in review for 3 days with no activity.

pp511
pp511 reviewed Aug 16, 2023
View reviewed changes
Copy link
Contributor

@pp511 pp511 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see a lot of overlap with the other PR. PWX-32648: Adding Install/Uninstall test. Would be easier to review once rebased. In the meanwhile, just some nits..

test/integration_test/utils/utils.go Outdated Show resolved Hide resolved
test/integration_test/utils/utils.go Outdated Show resolved Hide resolved
test/integration_test/utils/utils.go Outdated Show resolved Hide resolved
Base automatically changed from PWX-32648-master to master August 16, 2023 04:24
@github-actions github-actions bot added size/xs and removed size/s labels Aug 16, 2023
@nrevanna
PWX-32409: Adding Upgrade test
e56a649 
    This test case verifies that btrfs  datastores stays on upgrade on a
    testbed that qualifies for dmthin.
    TestStorageClusterDMthinUpgrade upgrades PX to 3.1 from 3.0 and 2.13
    over two iterations. It'll also verify that btrfs was installed.

Signed-off-by: Naveen Revanna <nrevanna@purestorage.com>
@github-actions github-actions bot added size/s and removed size/xs labels Aug 16, 2023
@nrevanna
Copy link
Contributor Author

@pp511 it should look better now.
I had taken care of it by rebasing against a feature branch. Looks like something got messed up. Now it should be cleaner.

pp511
pp511 approved these changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@pp511 pp511 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two nits. Looks good.

test/integration_test/basic_dmthin_test.go Outdated Show resolved Hide resolved
test/integration_test/basic_dmthin_test.go Outdated Show resolved Hide resolved
@nrevanna nrevanna merged commit 4b3595b into master Aug 16, 2023
8 checks passed
@nrevanna nrevanna deleted the PWX-32409-master branch August 16, 2023 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pp511 pp511 pp511 approved these changes

Assignees
No one assigned
Labels
area/integration-test size/s stage/approved stage/in-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nrevanna @pp511